Skip to content

Make the default value of n_features match the khiops core value#545

Merged
tramora merged 1 commit intomainfrom
543-n-features-default-value
Feb 13, 2026
Merged

Make the default value of n_features match the khiops core value#545
tramora merged 1 commit intomainfrom
543-n-features-default-value

Conversation

@tramora
Copy link
Collaborator

@tramora tramora commented Feb 3, 2026

  • KhiopsClassifier, KhiopsRegressor, KhiopsEncoder

Fixes #543


TODO Before Asking for a Review

  • Rebase your branch to the latest version of main (or main-v10)
  • Make sure all CI workflows are green
  • When adding a public feature/fix: Update the Unreleased section of CHANGELOG.md (no date)
  • Self-Review: Review "Files Changed" tab and fix any problems you find
  • API Docs (only if there are changes in docstrings, rst files or samples):
    • Check the docs build without warning: see the log of the API Docs workflow
    • Check that your changes render well in HTML: download the API Docs artifact and open index.html
    • If there are any problems it is faster to iterate by building locally the API Docs

Copy link
Member

@folmos-at-orange folmos-at-orange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog.

@tramora tramora force-pushed the 543-n-features-default-value branch from db77fe2 to 819bb4f Compare February 4, 2026 10:40
@tramora
Copy link
Collaborator Author

tramora commented Feb 4, 2026

Update the changelog.
Fixed

Copy link
Collaborator

@popescu-v popescu-v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor changes in the tests (see the comments).

- KhiopsClassifier, KhiopsRegressor, KhiopsEncoder
@tramora tramora force-pushed the 543-n-features-default-value branch from c7c2b73 to beb3014 Compare February 13, 2026 13:25
@tramora tramora merged commit b81ec6e into main Feb 13, 2026
18 checks passed
@tramora tramora deleted the 543-n-features-default-value branch February 13, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sklearn estimator n_features default value not coherent with core's max_features

3 participants